Scale values of type 'float' when returned from special sensor classes#330
Scale values of type 'float' when returned from special sensor classes#330
Conversation
|
Not yet tested on the EV3. |
WasabiFan
left a comment
There was a problem hiding this comment.
Would be good to test live, but it looks good in general.
|
So I did test this on the EV3, which resulted in 271f02a. But it seems I don't posses a single sensor that would both be listed in special sensors section and have a floating point value with non-zero decimals. All I could test is that |
|
Thanks for the update, I will test this when I get home later today and update this comment. UPDATE @ddemidov: I replaced core.py on my ev3 with the modified version for this commit. I was unable to find the liquid modified template file, but think it doesn't matter (?). When I test now it seems to work and returns the distance in centimeters: Looks good to me, thanks for fixing this so quickly! |
|
Sorry, did not see the updated comment (github does not send notifications on updates, so its better to create new comments). Thanks for testing! |
Fixes #329